Fix all golangci-lint errors #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses all golangci-lint errors by simplifying variable declarations, replacing format strings with standard library functions, and updating the pre-commit configuration to use the official golangci-lint repository.
Key changes:
- Simplified redundant variable type declarations to use short declaration syntax
- Replaced
fmt.Sprintfwith more appropriate functions (fmt.Fprintfandnet.JoinHostPort) - Removed unused constant and updated pre-commit hooks configuration
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/utils/utils.go | Replaced fmt.Sprintf with fmt.Fprintf for writing to hasher |
| pkg/users/users.go | Simplified variable declaration from explicit type to short form |
| pkg/tags/tags.go | Simplified variable declaration from explicit type to short form |
| pkg/settings/settings.go | Simplified variable declaration from explicit type to short form |
| pkg/nodes/nodes.go | Simplified variable declaration from explicit type to short form |
| pkg/logging/logstash.go | Replaced format string with net.JoinHostPort and removed unused constant |
| pkg/environments/environments.go | Simplified variable declaration from explicit type to short form |
| pkg/carves/carves.go | Simplified variable declaration from explicit type to short form |
| pkg/auditlog/audit.go | Simplified variable declaration from explicit type to short form |
| cmd/cli/query.go | Changed switch statement from condition-based to expression-based |
| cmd/admin/sessions/sessions.go | Fixed capitalization in error messages to follow Go conventions |
| cmd/admin/handlers/utils.go | Reordered imports alphabetically and replaced fmt.Sprintf with fmt.Fprintf |
| .pre-commit-config.yaml | Updated golangci-lint configuration to use official repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all lint errors and updated the pre-commit configuration for
golangci-lint